layout wip #4
Merged
layout wip #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rockin! 🎸 i'm gonna be tied up today and tomorrow but it'd be totally safe to stash anything static for reference in app/routes ie: app/routes/mel.tsx would be served up at http://localhost:3000/mel |
|
i just pushed a couple commits of my own to:
what's not working (yet)
sorry it took me so long to loop back and take a look at this PR! knowing you i shouldn't be suprised, but i couldn't believe you already took a pass at pretty much every layout in the app 🙃 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey this is a mess, but I'm not sure I'm gonna have any more time to work on it today, I didn't wanna hoard my progress! basically I'm just trying to get the main layout in there. I could keep plugging along in here (I should be able to make more headway tomorrow) or you could cannibalize parts of this or we could merge it—you're the boss!